<html>
<head><meta charset="utf-8"><title>rfc-2091 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html">rfc-2091</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="177208847"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177208847" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177208847">(Oct 03 2019 at 02:00)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span> btw <a href="https://github.com/rust-lang/rust/pull/65037" target="_blank" title="https://github.com/rust-lang/rust/pull/65037">https://github.com/rust-lang/rust/pull/65037</a></p>



<a name="177208915"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177208915" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177208915">(Oct 03 2019 at 02:02)</a>:</h4>
<p>nothing to do there, just giving the heads up that i'm doing it</p>



<a name="177209860"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177209860" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177209860">(Oct 03 2019 at 02:27)</a>:</h4>
<p>Added some comments <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="177210203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177210203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177210203">(Oct 03 2019 at 02:37)</a>:</h4>
<p><span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<a name="177210211"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177210211" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177210211">(Oct 03 2019 at 02:37)</a>:</h4>
<p>i think at this point you've read ayosec's code more closely than i have <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="177210263"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177210263" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177210263">(Oct 03 2019 at 02:38)</a>:</h4>
<p><span aria-label="joy" class="emoji emoji-1f602" role="img" title="joy">:joy:</span></p>



<a name="177210275"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177210275" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177210275">(Oct 03 2019 at 02:39)</a>:</h4>
<p><span class="user-mention" data-user-id="130111">@Adam Perry</span> btw, we can implement this in several steps (PRs)</p>



<a name="177210277"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177210277" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177210277">(Oct 03 2019 at 02:39)</a>:</h4>
<p>e.g. the AST + gating parts, MIR, etc.</p>



<a name="177210280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177210280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177210280">(Oct 03 2019 at 02:39)</a>:</h4>
<p>sure, wfm</p>



<a name="177215589"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177215589" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177215589">(Oct 03 2019 at 05:10)</a>:</h4>
<p><span class="user-mention" data-user-id="130111">@anp</span> btw, personally I just dispense with error codes and use <code>struct_span_err</code></p>



<a name="177215591"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177215591" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177215591">(Oct 03 2019 at 05:10)</a>:</h4>
<p>much less hassle</p>



<a name="177215597"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177215597" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177215597">(Oct 03 2019 at 05:10)</a>:</h4>
<p>cool, i'm not sure how to act on this advice :P</p>



<a name="177215606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177215606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177215606">(Oct 03 2019 at 05:11)</a>:</h4>
<p>eli5?</p>



<a name="177215609"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177215609" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177215609">(Oct 03 2019 at 05:11)</a>:</h4>
<p>basically: error codes are not required, it's "extra" if you do it</p>



<a name="177215741"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177215741" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177215741">(Oct 03 2019 at 05:15)</a>:</h4>
<p>ok, i think i'll put a little time into doing it and bail if i turn out to be lazy</p>



<a name="177215752"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177215752" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177215752">(Oct 03 2019 at 05:15)</a>:</h4>
<p>only semi related, i'm seeing these tests failing locally:</p>
<div class="codehilite"><pre><span></span>failures:
    [ui] ui/consts/miri_unleashed/mutable_references_ice.rs
    [ui] ui/pattern/const-pat-ice.rs
    [ui] ui/traits/cycle-cache-err-60010.rs
</pre></div>


<p>is this normal?</p>



<a name="177215793"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177215793" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177215793">(Oct 03 2019 at 05:16)</a>:</h4>
<p>what are the failures?</p>



<a name="177215950"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177215950" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177215950">(Oct 03 2019 at 05:21)</a>:</h4>
<p>here's one:</p>
<div class="codehilite"><pre><span></span>---- [ui] ui/traits/cycle-cache-err-60010.rs stdout ----
diff of stderr:

6      |
7      = note: required because of the requirements on the impl of `Query&lt;RootDatabase&gt;` for `ParseQuery`
8
-   error[E0275]: overflow evaluating the requirement `RootDatabase: SourceDatabase`
-     --&gt; $DIR/cycle-cache-err-60010.rs:30:6
-      |
-   LL | impl Database for RootDatabase {
-      |      ^^^^^^^^
-      |
-      = note: required because of the requirements on the impl of `Query&lt;RootDatabase&gt;` for `ParseQuery`
-      = note: required because it appears within the type `SalsaStorage`
-
-   error: aborting due to 2 previous errors
+   error: aborting due to previous error
19
20  For more information about this error, try `rustc --explain E0275`.
21


The actual stderr differed from the expected stderr.
</pre></div>



<a name="177216011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177216011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177216011">(Oct 03 2019 at 05:23)</a>:</h4>
<p>did you rebase atop master?</p>



<a name="177216013"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177216013" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177216013">(Oct 03 2019 at 05:23)</a>:</h4>
<p>might be a non-determinism issue otherwise</p>



<a name="177216528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177216528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177216528">(Oct 03 2019 at 05:38)</a>:</h4>
<p>yeah i'm at top of tree</p>



<a name="177216569"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177216569" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177216569">(Oct 03 2019 at 05:38)</a>:</h4>
<p>hm yeah cleaning seems to get rid of it for now</p>



<a name="177217984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177217984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177217984">(Oct 03 2019 at 06:16)</a>:</h4>
<p>ok two of them are thread names being unnamed on my machine instead of <code>&lt;rustc&gt;</code></p>



<a name="177217986"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177217986" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177217986">(Oct 03 2019 at 06:16)</a>:</h4>
<p>the third is the one i  pasted</p>



<a name="177217989"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177217989" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177217989">(Oct 03 2019 at 06:16)</a>:</h4>
<p>and they're still here after cleaning <span aria-label="confused" class="emoji emoji-1f615" role="img" title="confused">:confused:</span></p>



<a name="177219667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177219667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177219667">(Oct 03 2019 at 06:57)</a>:</h4>
<p>repro'ing on master and will file an issue once i figure out more detail</p>



<a name="177304923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177304923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177304923">(Oct 04 2019 at 02:06)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span> i think this is ready for re-review <a href="https://github.com/rust-lang/rust/pull/65037" target="_blank" title="https://github.com/rust-lang/rust/pull/65037">https://github.com/rust-lang/rust/pull/65037</a></p>



<a name="177386559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177386559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177386559">(Oct 04 2019 at 23:07)</a>:</h4>
<p>actually, just realized that the patch i started from didn't cover an important case. i pushed a failing test to the PR and am looking at how to fix it now</p>
<p>the issue is that the <code>#[track_caller]</code> attribute must be prohibited in traits, but <a href="https://github.com/anp/rust/blob/track-caller/src/librustc_typeck/check/wfcheck.rs#L176-L186" target="_blank" title="https://github.com/anp/rust/blob/track-caller/src/librustc_typeck/check/wfcheck.rs#L176-L186">https://github.com/anp/rust/blob/track-caller/src/librustc_typeck/check/wfcheck.rs#L176-L186</a> only covers items within the trait item itself, not in impl blocks for traits</p>
<p>i <em>think</em> what i want to do is add something here: <a href="https://github.com/anp/rust/blob/track-caller/src/librustc_typeck/check/wfcheck.rs#L193" target="_blank" title="https://github.com/anp/rust/blob/track-caller/src/librustc_typeck/check/wfcheck.rs#L193">https://github.com/anp/rust/blob/track-caller/src/librustc_typeck/check/wfcheck.rs#L193</a>, like</p>
<div class="codehilite"><pre><span></span>if method_sig.is_some() &amp;&amp; has_attr(impl_item.attrs, sym::track_caller) {
    // TODO figure out if the owning Item has a TraitRef?
}
</pre></div>


<p>i'm not sure how to find out about the owning Item from the ImplItem. i think i see a path like <code>let owning_item = tcx.expect_item(tcx.hir().def_index_to_hir_id(impl_item.hir.owner));</code>, is that the "right" way to look that up? it seems also possible that this information should be passed down in a different way, or that this check should occur elsewhere?</p>



<a name="177420601"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177420601" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177420601">(Oct 05 2019 at 16:13)</a>:</h4>
<p>(figured this out)</p>



<a name="177931552"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177931552" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Taylor Cramer <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177931552">(Oct 11 2019 at 17:53)</a>:</h4>
<p><span class="user-mention" data-user-id="130111">@anp</span></p>



<a name="177931667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177931667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177931667">(Oct 11 2019 at 17:54)</a>:</h4>
<p>sup? there's an rfc-2091 topic btw</p>



<a name="177931692"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177931692" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177931692">(Oct 11 2019 at 17:54)</a>:</h4>
<p>oh i see, from github</p>



<a name="177931708"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177931708" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177931708">(Oct 11 2019 at 17:55)</a>:</h4>
<p>ya i'm definitely misunderstanding something</p>



<a name="177931828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177931828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Taylor Cramer <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177931828">(Oct 11 2019 at 17:56)</a>:</h4>
<p>Look at the macros in this file for an example: <a href="https://github.com/rust-lang/rust/blob/master/src/libstd/macros.rs#L56" target="_blank" title="https://github.com/rust-lang/rust/blob/master/src/libstd/macros.rs#L56">https://github.com/rust-lang/rust/blob/master/src/libstd/macros.rs#L56</a></p>



<a name="177931841"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177931841" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Taylor Cramer <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177931841">(Oct 11 2019 at 17:56)</a>:</h4>
<p><code>#[allow_internal_unstable(whatever_unstable_feature_you_want_to_use_from_inside_the_expanded_macro)]</code> is what you want</p>



<a name="177931872"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177931872" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177931872">(Oct 11 2019 at 17:57)</a>:</h4>
<p>sweeet</p>



<a name="177931882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177931882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Taylor Cramer <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177931882">(Oct 11 2019 at 17:57)</a>:</h4>
<blockquote>
<p>rfc-2091 topic btw</p>
</blockquote>
<p>oh, sorry, I didn't see that. We can move there if you have more q's</p>



<a name="177931903"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177931903" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Taylor Cramer <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177931903">(Oct 11 2019 at 17:58)</a>:</h4>
<p>actually, IIRC there's some way to merge streams?</p>



<a name="177931995"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177931995" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177931995">(Oct 11 2019 at 17:58)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/47809#issuecomment-541163961" target="_blank" title="https://github.com/rust-lang/rust/issues/47809#issuecomment-541163961">https://github.com/rust-lang/rust/issues/47809#issuecomment-541163961</a></p>



<a name="177932008"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177932008" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Taylor Cramer <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177932008">(Oct 11 2019 at 17:59)</a>:</h4>
<p>there we go</p>



<a name="177932010"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177932010" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177932010">(Oct 11 2019 at 17:59)</a>:</h4>
<p>i dont think there is, also insert ghostbusters reference here</p>



<a name="177932026"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177932026" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Taylor Cramer <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177932026">(Oct 11 2019 at 17:59)</a>:</h4>
<p>I just did it</p>



<a name="177932054"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177932054" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177932054">(Oct 11 2019 at 17:59)</a>:</h4>
<p>merge != cross<br>
you <em>set me up</em> for it</p>



<a name="177932062"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177932062" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177932062">(Oct 11 2019 at 17:59)</a>:</h4>
<p>:P</p>



<a name="177932119"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177932119" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177932119">(Oct 11 2019 at 18:00)</a>:</h4>
<p>oh wait these are actually called topics not streams</p>



<a name="177932138"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177932138" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177932138">(Oct 11 2019 at 18:00)</a>:</h4>
<p>nmlol</p>



<a name="177932149"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/177932149" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#177932149">(Oct 11 2019 at 18:00)</a>:</h4>
<p>i'm a very proficient zulip user.</p>



<a name="179183673"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/179183673" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#179183673">(Oct 27 2019 at 19:33)</a>:</h4>
<p>@Centril you around to r+ this now that CI is passing again? <a href="https://github.com/rust-lang/rust/pull/65664" target="_blank" title="https://github.com/rust-lang/rust/pull/65664">https://github.com/rust-lang/rust/pull/65664</a><br>
think i have all of @eddyb's nits addressed and fixed the query hashing issue</p>



<a name="179183680"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/179183680" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#179183680">(Oct 27 2019 at 19:33)</a>:</h4>
<p><span class="user-mention" data-user-id="126931">@centril</span> apparently i dont know how to tag in zulip</p>



<a name="179183731"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/179183731" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#179183731">(Oct 27 2019 at 19:34)</a>:</h4>
<p><span class="user-mention" data-user-id="130111">@anp</span> I would prefer for eddyb to do the approving</p>



<a name="179183740"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/179183740" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#179183740">(Oct 27 2019 at 19:35)</a>:</h4>
<p>they are easier to reach on discord</p>



<a name="179183867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/179183867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#179183867">(Oct 27 2019 at 19:38)</a>:</h4>
<p>kk</p>



<a name="179185528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/179185528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#179185528">(Oct 27 2019 at 20:27)</a>:</h4>
<p>they were still awake!</p>



<a name="179185531"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rfc-2091/near/179185531" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> anp <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rfc-2091.html#179185531">(Oct 27 2019 at 20:27)</a>:</h4>
<p>miracle.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>